lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Suggested code change : Simple : Scale pdflush threads from desktop to server
Date
Sorry,

IF Not rate limit. Missing not / !.
if (!(printk_ratelimit() )) {


Mitchell Erblich
================

On Jul 10, 2009, at 6:25 PM, Mitchell Erblich wrote:

> Group,
>
> pdflush threads clean dirty pages
>
> Under the past simple assumption that a greater number of
> page daemon threads will have the TENDENCY to clean
> the pages faster.
>
> Another assumption is that a server will have at least 2x / 4x the
> number of drives and memory, so allocating more pdflush() threads
> makes sense.
>
> Relying on a recent change, code base on whether the system is
> a desktop or a server, scale the number of pdthreads() which would
> result in the below code change.
>
> The suggestion is to double the MIN number of threads and set the
> MAX number to 4x.
>
> ./mm/pdflush.c
> /* Scale for a server */
> #define MIN_PDFLUSH_THREADS 4 /* 2x desktop value */
> #define MAX_PDFLUSH_THREADS 32 /* 4x desktop value */
>
>
> /*
> * secondary suggestion is to add a DEBUG type /var/log/system
> messages that
> * will rate limit independent of desktop or server.
> */
>
> else if (nr_pdflush_threads == MAX_PDFLUSH_THREADS) {
> /* optional PDFLUSH msg */
> if (printk_ratelimit() {
> printk(KERN_INFO
> "MAX_PDFLUSH_THREADS Limited\n");
> }
> }
>
>
>



\
 
 \ /
  Last update: 2009-07-11 03:51    [W:0.047 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site