lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateFri, 10 Jul 2009 13:07:52 -0700 (PDT)
FromLinus Torvalds <>
SubjectRe: [PATCH] dma-debug: Fix the overlap() function to be correct and readable


On Fri, 10 Jul 2009, Ingo Molnar wrote:
>
> How about the patch below? Lightly tested.
>
> if (!PageHighMem(page)) {
> - void *addr = ((char *)page_address(page)) + offset;
> + void *addr = (void *)page_address(page) + offset;
> +

Why is that 'void *' cast there? page_address() is already a void *.

Other than that it obviously looks good to me. But I never see my own
bugs.

Linus


\
 
 \ /
  Last update: 2009-10-18 23:28    [from the cache]
©2003-2010