Messages in this thread |  | | | Date | Fri, 10 Jul 2009 13:07:52 -0700 (PDT) | | From | Linus Torvalds <> | | Subject | Re: [PATCH] dma-debug: Fix the overlap() function to be correct and readable |
| |
On Fri, 10 Jul 2009, Ingo Molnar wrote: > > How about the patch below? Lightly tested. > > if (!PageHighMem(page)) { > - void *addr = ((char *)page_address(page)) + offset; > + void *addr = (void *)page_address(page) + offset; > +
Why is that 'void *' cast there? page_address() is already a void *.
Other than that it obviously looks good to me. But I never see my own bugs.
Linus
|  |