lkml.org 
[lkml]   [2009]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] sched: Remove SYSTEM_RUNNING checks from cond_resched*()
Hi!

> > That said, I do agree that maybe SYSTEM_RUNNING isn't the right check.
> > Testing that the scheduler is initialized may be the more correct one. I
> > think the SYSTEM_RUNNING one just comes from that being used for other
> > debug issues.
>
> Agreed. system_state is too general.
>
> If we specifically want to know whether it is safe to call schedule() then
> let's create a global boolean it_is_safe_to_call_schedule and test that,
> rather than testing something which indirectly and unreliably implies "it
> is safe to call schedule". If that boolean already exists then no-brainer.

or maybe we could embed that check into schedule(), just returning
when scheduler is not ready?

And I always wondered... system_state is not protected by any kind of
lock and is not atomic_t... Does it all work by mistake?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-07-10 14:11    [W:0.078 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site