Messages in this thread | | | Date | Fri, 10 Jul 2009 07:18:48 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support |
| |
* Len Brown <lenb@kernel.org> wrote:
> Feng Tang (10): > SFI, x86: add CONFIG_SFI > SFI: document boot param "sfi=off" > SFI: create include/linux/sfi.h > SFI: add core support > ACPI, x86: remove ACPI dependency on some IO-APIC routines > SFI: add x86 support > SFI, x86: hook e820() for memory map initialization > SFI: Enable SFI to parse ACPI tables > SFI, PCI: Hook MMCONFIG > SFI: add boot-time initialization hooks
Now that commit quality is all the rage, let me point out a (trivial) detail that could be improved: patch title capitalization.
In particular for commits touching arch/x86/ we try to standardize on capitalizing the word after the 'x86: ' tag. But in the above titles the capitalization is mixed-case:
[aligned vertically for easier readability ]
> SFI, x86: add CONFIG_SFI > SFI: document boot param "sfi=off" > SFI: create include/linux/sfi.h > SFI: add core support > ACPI, x86: remove ACPI dependency on some IO-APIC routines > SFI: add x86 support > SFI, x86: hook e820() for memory map initialization > SFI: Enable SFI to parse ACPI tables > SFI, PCI: Hook MMCONFIG > SFI: add boot-time initialization hooks
So it would be more consistent to have:
> SFI, x86: Add CONFIG_SFI > SFI: Document boot param "sfi=off" > SFI: Create include/linux/sfi.h > SFI: Add core support > ACPI, x86: Remove ACPI dependency on some IO-APIC routines > SFI: Add x86 support > SFI, x86: Hook e820() for memory map initialization > SFI: Enable SFI to parse ACPI tables > SFI, PCI: Hook MMCONFIG > SFI: Add boot-time initialization hooks
( Capitalizing like that has the added (minor) benefit of making it slightly easier to read these titles - the 'real' natural language sentence portion of the title begins with a capital letter. )
Thanks,
Ingo
| |