Messages in this thread | | | Date | Wed, 01 Jul 2009 08:57:50 +0200 | From | Marek Szyprowski <> | Subject | RE: [PATCH] [drivers] [SPI] SPI_GPIO: add support for controllers without MISO or MOSI pin |
| |
Hello,
On Wednesday, July 01, 2009 3:39 AM, David Brownell wrote:
> > --- a/drivers/spi/spi_bitbang.c > > +++ b/drivers/spi/spi_bitbang.c > > @@ -392,6 +392,22 @@ int spi_bitbang_transfer(struct spi_device *spi, struct spi_message *m) > > unsigned long flags; > > int status = 0; > > > > + if (spi->master->flags & SPI_MASTER_NO_RX) { > > + struct spi_transfer *xfer; > > + list_for_each_entry(xfer, &m->transfers, transfer_list) { > > + if (xfer->rx_buf) > > + return -EINVAL; > > + } > > + } > > Actually these two loops should merge, and likely move with > spi_async() into the spi.c core code ... I'll split this > support into a separate patch.
Ok.
I created two separate loops because I thought that it will be faster, especially when the check must be done for each transfer message request.
Best regards -- Marek Szyprowski Samsung Poland R&D Center
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |