lkml.org 
[lkml]   [2009]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cdc-acm: work around some broken devices
    On Wed, 1 Jul 2009, Arseniy Lartsev wrote:

    > On Wednesday 01 July 2009 15:37:48 Oliver Neukum wrote:
    > > Yes, exactly. Please add greg@kroah.com into CC, add a Signed-off-by line
    > > and resend.
    > ok
    >
    > Signed-off-by: Arseniy Lartsev <ars3n at yandex dot ru>
    > --- a/drivers/usb/class/cdc-acm.c
    > +++ b/drivers/usb/class/cdc-acm.c
    > @@ -387,6 +387,7 @@ static void acm_rx_tasklet(unsigned long
    > struct acm_ru *rcv;
    > unsigned long flags;
    > unsigned char throttled;
    > + struct usb_host_endpoint *ep;
    >
    > dbg("Entering acm_rx_tasklet");
    >
    > @@ -462,11 +463,20 @@ urbs:
    >
    > rcv->buffer = buf;
    >
    > - usb_fill_bulk_urb(rcv->urb, acm->dev,
    > - acm->rx_endpoint,
    > - buf->base,
    > - acm->readsize,
    > - acm_read_bulk, rcv);
    > + ep = (usb_pipein(acm->rx_endpoint) ? acm->dev->ep_in : acm->dev->ep_out)
    > + [usb_pipeendpoint(acm->rx_endpoint)];

    Isn't acm->rx_endpoint always going to be IN?

    Alan Stern



    \
     
     \ /
      Last update: 2009-07-01 16:37    [W:0.048 / U:30.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site