lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 02/60] nfs: Fix NFS v4 client handling of MAY_EXEC in nfs_permission.
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Frank Filz <ffilzlnx@us.ibm.com>

    commit 7ee2cb7f32b299c2b06a31fde155457203e4b7dd upstream.

    The problem is that permission checking is skipped if atomic open is
    possible, but when exec opens a file, it just opens it O_READONLY which
    means EXEC permission will not be checked at that time.

    This problem is observed by the following sequence (executed as root):

    mount -t nfs4 server:/ /mnt4
    echo "ls" >/mnt4/foo
    chmod 744 /mnt4/foo
    su guest -c "mnt4/foo"

    Signed-off-by: Frank Filz <ffilzlnx@us.ibm.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Tested-by: Eugene Teo <eugeneteo@kernel.sg>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfs/dir.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/fs/nfs/dir.c
    +++ b/fs/nfs/dir.c
    @@ -1925,7 +1925,8 @@ int nfs_permission(struct inode *inode,
    case S_IFREG:
    /* NFSv4 has atomic_open... */
    if (nfs_server_capable(inode, NFS_CAP_ATOMIC_OPEN)
    - && (mask & MAY_OPEN))
    + && (mask & MAY_OPEN)
    + && !(mask & MAY_EXEC))
    goto out;
    break;
    case S_IFDIR:



    \
     
     \ /
      Last update: 2009-06-10 05:37    [W:2.684 / U:0.920 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site