lkml.org 
[lkml]   [2009]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 05/38] s390: hibernation support for s390
    On Mon, 8 Jun 2009 08:44:51 +0200
    Pavel Machek <pavel@ucw.cz> wrote:


    > > Index: linux-2.6/arch/s390/power/swsusp.c
    > > ===================================================================
    > > --- /dev/null
    > > +++ linux-2.6/arch/s390/power/swsusp.c
    > > @@ -0,0 +1,31 @@
    > > +/*
    > > + * Support for suspend and resume on s390
    > > + *
    > > + * Copyright IBM Corp. 2009
    > > + *
    > > + * Author(s): Hans-Joachim Picht <hans@linux.vnet.ibm.com>
    > > + *
    > > + */
    > > +
    > > +#include <linux/suspend.h>
    > > +#include <linux/gfp.h>
    > > +#include <linux/cpu.h>
    > > +#include <linux/smp.h>
    > > +#include <linux/cpumask.h>
    > > +#include <asm/ipl.h>
    > > +#include <asm/processor.h>
    >
    > Empty functions do not need 1000 includes...

    Thanks for spotting this. I will remove these.

    > > +/*
    > > + * save CPU registers before creating a hibernation image and
    > > before
    > > + * restoring the memory state from it
    > > + */
    > > +void save_processor_state(void)
    > > +{
    > > +}
    > > +
    > > +/*
    > > + * restore the contents of CPU registers
    > > + */
    > > +void restore_processor_state(void)
    > > +{
    > > +}
    >
    > ...and explaining why the functions can be emmpty would be nice.

    I integrated the code for this in the assembly backend in the
    swsusp_arch_suspend & swsusp_arch_resume functions.

    With best regards,

    --Hans


    \
     
     \ /
      Last update: 2009-06-09 15:37    [W:0.024 / U:60.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site