Messages in this thread |  | | | Date | Mon, 08 Jun 2009 15:24:58 +0200 | | From | Oliver Hartkopp <> | | Subject | Re: [PATCH 3/5] can: af_can.c use rcu_barrier() on module unload. |
Jesper Dangaard Brouer wrote: > This module uses rcu_call() thus it should use rcu_barrier() > on module unload. > > Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Thanks Jesper for pointing at this issue!
Acked-By: Oliver Hartkopp <oliver@hartkopp.net>
Btw. i do agree with theses patches to be a bug fix that should go into 2.6.30-rc8 as well as into the stable series.
Best regards, Oliver
> --- > > net/can/af_can.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/net/can/af_can.c b/net/can/af_can.c > index 10f0528..e733725 100644 > --- a/net/can/af_can.c > +++ b/net/can/af_can.c > @@ -903,6 +903,8 @@ static __exit void can_exit(void) > } > spin_unlock(&can_rcvlists_lock); > > + rcu_barrier(); /* Wait for completion of call_rcu()'s */ > + > kmem_cache_destroy(rcv_cache); > } > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |