Messages in this thread | | | From | "Gao, Yunpeng" <> | Date | Mon, 8 Jun 2009 11:34:04 +0800 | Subject | RE: [PATCH 1/2]Intel Moorestown NAND driver patch for mainline |
| |
>-----Original Message----- >From: Greg KH [mailto:gregkh@suse.de] >Sent: 2009年6月6日 22:58 >To: Jiri Slaby >Cc: Gao, Yunpeng; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org >Subject: Re: [PATCH 1/2]Intel Moorestown NAND driver patch for mainline > >On Sat, Jun 06, 2009 at 01:11:51PM +0200, Jiri Slaby wrote: >> On 06/06/2009 06:44 PM, Yunpeng Gao wrote: >> > diff --git a/drivers/staging/mrst_nand/ffsport.c >b/drivers/staging/mrst_nand/ffsport.c >> > new file mode 100644 >> > index 0000000..5a919f4 >> > --- /dev/null >> > +++ b/drivers/staging/mrst_nand/ffsport.c >> > @@ -0,0 +1,953 @@ >> > +void glob_udelay(unsigned long usecs) >> > +{ >> > + udelay(usecs); >> > +} >> > + >> > +void glob_mdelay(unsigned long msecs) >> > +{ >> > + mdelay(msecs); >> > +} >> >> Unneeded wrappers. > ><snip> > >Thanks for the review, this is one reason why it's in the staging >directory :) > >Hopefully someone can send follow-on patches implementing these fixups >(hint...) > >greg k-h
Hi Greg,
Thanks a lot for all the comments and reviewing works of community. This NAND driver is still under development. Some functional features are not implemented yet. Also, I know that there's a lot of thing I can do to improve the quality of the driver code.
I plan to enable the new functional features, adjust the data structure, lower the memory footprint in later one or two months. And will submit follow-on patches after I finished those works. I'll try to address the comments of Jiri Slaby in those patches.
Thanks.
Rgds, Yunpeng
| |