Messages in this thread |  | | | From | Florian Fainelli <> | | Subject | Re: add bcm47xx watchdog driver | | Date | Sat, 6 Jun 2009 12:58:02 +0200 |
| |
Le Friday 05 June 2009 16:58:42 castet.matthieu@free.fr, vous avez écrit : > Hi Florian, > > Quoting Florian Fainelli <florian@openwrt.org>: > > Your driver looks good, could you turn this into a platform device/driver > > instead ? You declare bcm47xx_wdt_platform_device which is unused and you > > also declare a MODULE_ALIAS which suggets it is one. > > What's the advantage of using platform device/driver ? > Not all watchdog driver use it (for example softdog). > This seems useless in this case because the driver don't have any resource, > don't care about suspend/resume and add complexity in the code (2 registers > in module probe, ...).
Indeed, I was suggesting that either you turn it into a full platform driver or your remove references to it (bcm47xx_wdt_platform_device and MODULE_ALIAS). -- Best regards, Florian Fainelli Email : florian@openwrt.org http://openwrt.org ------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |