Messages in this thread | | | Date | Sat, 6 Jun 2009 14:35:18 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] integrity: fix IMA inode leak |
| |
On Sat, 6 Jun 2009, Linus Torvalds wrote: > > On Sat, 6 Jun 2009, Hugh Dickins wrote: > > > > CONFIG_IMA=y inode activity leaks iint_cache and radix_tree_node objects > > until the system runs out of memory. Nowhere is calling ima_inode_free() > > a.k.a. ima_iint_delete(). Fix that by calling it from destroy_inode(). > > Shouldn't we call it from "security_inode_free()" instead? And shouldn't > it be allocated in "security_inode_alloc()"? That sounds like the correct > nesting here, since the whole integrity thing is under the security > module. > > Hmm?
Oh well. I applied the patch as-is, since it seems to fix a real issue.
But I do think fs/inode.c shouldn't care about things like that, and have it internal to security_inode_alloc/free(). But I guess that's a separate cleanup.
Linus
| |