lkml.org 
[lkml]   [2009]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 34/39] scripts/headers_check.pl: correct RE in header CONFIG leak check
    Date
    From: Robert P. J. Day <rpjday@crashcourse.ca>

    Correct the regular expression in scripts/headers_check.pl to include '_'
    as a valid character in the class; otherwise, the check will report a
    "leaked" symbol of CONFIG_A_B_C as merely CONFIG_A.

    This patch will make no difference whatsoever in the current kernel tree
    as the call to the perl routine that does that check is currently
    commented out:

    &check_include();
    &check_asm_types();
    &check_sizetypes();
    &check_prototypes();
    # Dropped for now. Too much noise &check_config();

    However, I noticed that problem when I was building the yum downloadable
    kernel source rpm for fedora 11 (beta), which *does* run that check, and
    that's where the problem became obvious.

    Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
    Cc: David Woodhouse <dwmw2@infradead.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
    ---
    scripts/headers_check.pl | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
    index 3923888..e3fb949 100644
    --- a/scripts/headers_check.pl
    +++ b/scripts/headers_check.pl
    @@ -74,7 +74,7 @@ sub check_declarations

    sub check_config
    {
    - if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9]+)[^a-zA-Z0-9]/) {
    + if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) {
    printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n";
    }
    }
    --
    1.6.3.rc3.40.g75b44


    \
     
     \ /
      Last update: 2009-06-06 01:55    [W:0.019 / U:1.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site