lkml.org 
[lkml]   [2009]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: add bcm47xx watchdog driver
    Hi Florian,

    Quoting Florian Fainelli <florian@openwrt.org>:

    >
    > Your driver looks good, could you turn this into a platform device/driver
    > instead ? You declare bcm47xx_wdt_platform_device which is unused and you
    > also declare a MODULE_ALIAS which suggets it is one.
    What's the advantage of using platform device/driver ?
    Not all watchdog driver use it (for example softdog).
    This seems useless in this case because the driver don't have any resource,
    don't care about suspend/resume and add complexity in the code (2 registers in
    module probe, ...).


    Matthieu


    \
     
     \ /
      Last update: 2009-06-05 17:01    [W:0.053 / U:29.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site