lkml.org 
[lkml]   [2009]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2.1 17/17] VFS: use is_sb_dirty helper
    Date
    From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

    ... instead of checking 's_dirt' directly. This is just
    a little cleaner and more consistent. We have only 3
    VFS helpers which access 's_dirt' now.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    ---
    fs/super.c | 4 ++--
    fs/sync.c | 4 ++--
    2 files changed, 4 insertions(+), 4 deletions(-)
    diff --git a/fs/super.c b/fs/super.c
    index 2ea1586..ef9a24a 100644
    --- a/fs/super.c
    +++ b/fs/super.c
    @@ -415,12 +415,12 @@ void sync_supers(void)
    spin_lock(&sb_lock);
    restart:
    list_for_each_entry(sb, &super_blocks, s_list) {
    - if (sb->s_op->write_super && sb->s_dirt) {
    + if (sb->s_op->write_super && is_sb_dirty(sb)) {
    sb->s_count++;
    spin_unlock(&sb_lock);

    down_read(&sb->s_umount);
    - if (sb->s_root && sb->s_dirt)
    + if (sb->s_root && is_sb_dirty(sb))
    sb->s_op->write_super(sb);
    up_read(&sb->s_umount);

    diff --git a/fs/sync.c b/fs/sync.c
    index e9d56f6..12f36d7 100644
    --- a/fs/sync.c
    +++ b/fs/sync.c
    @@ -33,7 +33,7 @@ static int __sync_filesystem(struct super_block *sb, int wait)
    else
    sync_quota_sb(sb, -1);
    sync_inodes_sb(sb, wait);
    - if (sb->s_dirt && sb->s_op->write_super)
    + if (is_sb_dirty(sb) && sb->s_op->write_super)
    sb->s_op->write_super(sb);
    if (sb->s_op->sync_fs)
    sb->s_op->sync_fs(sb, wait);
    @@ -162,7 +162,7 @@ int file_fsync(struct file *filp, struct dentry *dentry, int datasync)

    /* sync the superblock to buffers */
    sb = inode->i_sb;
    - if (sb->s_dirt && sb->s_op->write_super)
    + if (is_sb_dirty(sb) && sb->s_op->write_super)
    sb->s_op->write_super(sb);

    /* .. finally sync the buffers to disk */
    --
    1.6.0.6


    \
     
     \ /
      Last update: 2009-06-05 13:33    [from the cache]
    ©2003-2014 Jasper Spaans. Advertise on this site