lkml.org 
[lkml]   [2009]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] kbuild: fix headers_check.pl
Arnd Bergmann wrote:
> On Friday 05 June 2009, Amerigo Wang wrote:
>> -sub check_prototypes
>> +sub check_declarations
>> {
>> - if ($line =~ m/^\s*extern\b/) {
>> - printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
>> + if ($line =~m/^\s*extern\b/) {
>> + if ($line =~ m/^\s*extern\b.*\(.*\)/) {
>> + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
>> + } else {
>> + printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n";
>> + }
>> }
>> }
>
> I don't think we really need that distinction here, the old
> text applies to both. But please find a way to get rid of
> the "extern's".
>
> http://angryflower.com/bobsqu.gif

Hehe, made me smile :-)


\
 
 \ /
  Last update: 2009-06-05 13:31    [W:0.169 / U:0.032 seconds]
©2003-2011 Jasper Spaans. Advertise on this site