Messages in this thread | | | Date | Thu, 4 Jun 2009 22:16:49 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 1/6] headers_check fix: arm, hwcap.h |
| |
On Thu, Jun 04, 2009 at 01:53:07PM +0100, Russell King wrote: > On Thu, Jun 04, 2009 at 05:57:56PM +0530, Jaswinder Singh Rajput wrote: > > fix the following 'make headers_check' warning: > > I think headers_check needs fixing - there's nothing wrong with the > code as it presently stands except the tools obviously can't properly > parse C preprocessor statements.
You are correct that headers_ceck is limited here and this patch take some valid code and refactor it to make it headers_check compatible.
But the resulting code is as readable as before and we keep the noise down when checking our exported headers.
Considering the effort needed to fix the tool I would request you to take the patch anyway.
Sam
| |