lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 35/35] dm: sysfs skip output when device is being destroyed
    2.6.29-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Milan Broz <mbroz@redhat.com>

    commit 4d89b7b4e4726893453d0fb4ddbb5b3e16353994 upstream.

    Do not process sysfs attributes when device is being destroyed.

    Otherwise code can cause
    BUG_ON(test_bit(DMF_FREEING, &md->flags));
    in dm_put() call.

    Signed-off-by: Milan Broz <mbroz@redhat.com>
    Signed-off-by: Alasdair G Kergon <agk@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/md/dm.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/md/dm.c
    +++ b/drivers/md/dm.c
    @@ -1728,6 +1728,10 @@ struct mapped_device *dm_get_from_kobjec
    if (&md->kobj != kobj)
    return NULL;

    + if (test_bit(DMF_FREEING, &md->flags) ||
    + test_bit(DMF_DELETING, &md->flags))
    + return NULL;
    +
    dm_get(md);
    return md;
    }



    \
     
     \ /
      Last update: 2009-07-01 03:03    [W:0.020 / U:148.624 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site