lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 14/35] USB: usbtmc: fix switch statment
    2.6.29-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Greg Kroah-Hartman <gregkh@suse.de>

    commit a92b63e7e4c185b4dd9e87762e2cb716e54482d0 upstream.

    Steve Holland pointed out that we forgot to call break; in the switch
    statment. This probably resolves a lot of the bug reports I've gotten
    for the driver lately.

    Stupid me...

    Reported-by: Steve Holland <sdh4@iastate.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/usb/class/usbtmc.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/drivers/usb/class/usbtmc.c
    +++ b/drivers/usb/class/usbtmc.c
    @@ -927,21 +927,27 @@ static long usbtmc_ioctl(struct file *fi
    switch (cmd) {
    case USBTMC_IOCTL_CLEAR_OUT_HALT:
    retval = usbtmc_ioctl_clear_out_halt(data);
    + break;

    case USBTMC_IOCTL_CLEAR_IN_HALT:
    retval = usbtmc_ioctl_clear_in_halt(data);
    + break;

    case USBTMC_IOCTL_INDICATOR_PULSE:
    retval = usbtmc_ioctl_indicator_pulse(data);
    + break;

    case USBTMC_IOCTL_CLEAR:
    retval = usbtmc_ioctl_clear(data);
    + break;

    case USBTMC_IOCTL_ABORT_BULK_OUT:
    retval = usbtmc_ioctl_abort_bulk_out(data);
    + break;

    case USBTMC_IOCTL_ABORT_BULK_IN:
    retval = usbtmc_ioctl_abort_bulk_in(data);
    + break;
    }

    mutex_unlock(&data->io_mutex);



    \
     
     \ /
      Last update: 2009-07-01 03:03    [W:0.022 / U:1.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site