Messages in this thread |  | | | Date | Tue, 30 Jun 2009 17:27:02 -0700 | | Subject | Re: [PATCH 2/2] cgroup: exlclude release rmdir | | From | Paul Menage <> |
| |
On Tue, Jun 30, 2009 at 5:09 PM, KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> wrote: > On Wed, 1 Jul 2009 08:40:37 +0900 > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote: > >> On Tue, 30 Jun 2009 09:18:03 -0700, Paul Menage <menage@google.com> wrote: >> > On Tue, Jun 30, 2009 at 2:23 AM, KAMEZAWA >> > Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com> wrote: >> > > This patch is _not_ tested by Nishimura. >> > >> > True, but it's functionally identical to, and simpler than, the one >> > that was tested. >> > >> I agree. >> I'll test with both of these patches folded. >> > Hm,ok. I'll post merged one today. > But I don't like cosmeticized bugfix patch ;( >
It only looks "cosmeticized" because of the evolution of your fix. The first patch added a new function that exposed internal details of cgroups, and the second patch removes the addition in favour of a different new function that doesn't expose internal details as much; a single patch that just adds the simpler new function is easier to judge as intuitively correct (separately from Daisuke's testing) than one that exposes more internal details. Paul
|  |