Messages in this thread | | | Date | Tue, 30 Jun 2009 11:04:49 -0700 | From | Gary Hade <> | Subject | Re: [PATCH 1/3] x86/pci: fix boundary checking when using root CRS |
| |
On Mon, Jun 29, 2009 at 06:16:03PM -0700, Jesse Barnes wrote: > On Wed, 24 Jun 2009 19:01:19 -0700 > Yinghai Lu <yinghai@kernel.org> wrote: > > > > > don't touch info->res_num if we are out of space > > > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > > Gary, any comments on these?
Jesse, "[PATCH 1/3] x86/pci: fix boundary checking when using root CRS" which convinced that my code was incorrect and "[PATCH 2/3] x86/pci: get root CRS before scan childs -v3" look good to me from both code review and functional [1] standpoints. Acked-by: <garyhade@us.ibm.com> Tested-by: <garyhade@us.ibm.com>
[1] Successful boot of patched 2.6.31-rc1 with pci=use_crs followed by successful hot-add and hot-remove of PCI-X and PCIe cards on an IBM x3850.
Thanks Yinghai.
Gary
-- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 garyhade@us.ibm.com http://www.ibm.com/linux/ltc
| |