lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + memory-hotplug-update-zone-pcp-at-memory-online.patch added to -mm tree
On Tue, 30 Jun 2009, Shaohua Li wrote:

> > foreach possible cpu?
> Just follows zone_pcp_init(), do you think we should change that too?

I plan to change that but for now this would be okay.

> > > + struct per_cpu_pageset *pset;
> > > + struct per_cpu_pages *pcp;
> > > +
> > > + pset = zone_pcp(zone, cpu);
> > > + pcp = &pset->pcp;
> > > +
> > > + local_irq_save(flags);
> > > + free_pages_bulk(zone, pcp->count, &pcp->list, 0);
> >
> > There are no pages in the pageset since the pcp batch is zero right?
> It might not be zero for a populated zone, see above comments.

But you are populating an unpopulated zone?



\
 
 \ /
  Last update: 2009-06-30 16:25    [W:0.050 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site