Messages in this thread | | | Date | Tue, 30 Jun 2009 10:21:34 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: + memory-hotplug-update-zone-pcp-at-memory-online.patch added to -mm tree |
| |
On Tue, 30 Jun 2009, Shaohua Li wrote:
> > foreach possible cpu? > Just follows zone_pcp_init(), do you think we should change that too?
I plan to change that but for now this would be okay.
> > > + struct per_cpu_pageset *pset; > > > + struct per_cpu_pages *pcp; > > > + > > > + pset = zone_pcp(zone, cpu); > > > + pcp = &pset->pcp; > > > + > > > + local_irq_save(flags); > > > + free_pages_bulk(zone, pcp->count, &pcp->list, 0); > > > > There are no pages in the pageset since the pcp batch is zero right? > It might not be zero for a populated zone, see above comments.
But you are populating an unpopulated zone?
| |