Messages in this thread | | | Date | Tue, 30 Jun 2009 14:09:45 +0100 | From | Alan Cox <> | Subject | Re: [PATCH][RFC] asm-generic:remove calling flush_write_buffers() in dma_sync_*_for_cpu |
| |
> > What about non x86 - this is asm-generic you are playing with and its the > > kind of change that causes evil really hard to track down and subtle > > corruptions and user data loss if you get it wrong. > > Non-x86 is the real motivation for the patch, because the flush_write_buffers > call in this file is currently not implemented and causes build errors > on everything but x86, frv, ia64 and m32r, where the latter two implement > it as an empty macro.
Ok so the FRV would grow a similar no iommu patch to the x86.
> The only users of the file right now are x86 and ia64, and ia64 only added > the empty flush_write_buffers() definition in order to use it.
That now all makes sense.
| |