lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [patch] x86: fix arch/x86/lib/clear_page_64.S::clear_page_c annotation
FromMike Galbraith <>
DateTue, 30 Jun 2009 15:00:20 +0200
On Tue, 2009-06-30 at 13:42 +0200, Alexander van Heukelum wrote:
> Hi Mike,
>
> I agree with the code, but I do have a remark...
>
> The ENTRY() macro already includes the ALIGN, so you could get
> rid of the preceding ALIGN. But it's just a neatness thing, because
> two consecutive ALIGNS don't change the resulting binary.
>
> At any rate:
>
> Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
>
> (maybe the x86-committer feels comfortable enough to remove the ALIGN ;)
> )

No doubt, but I can save him the trouble ;-)

x86: fix incorrect arch/x86/lib/clear_page_64.S::clear_page_c annotation.

Signed-off-by: Mike Galbraith <efault@gmx.de>
Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>
LKML-Reference: <new-submission>

---
arch/x86/lib/clear_page_64.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/arch/x86/lib/clear_page_64.S
===================================================================
--- linux-2.6.orig/arch/x86/lib/clear_page_64.S
+++ linux-2.6/arch/x86/lib/clear_page_64.S
@@ -5,15 +5,14 @@
* Zero a page.
* rdi page
*/
- ALIGN
-clear_page_c:
+ENTRY(clear_page_c)
CFI_STARTPROC
movl $4096/8,%ecx
xorl %eax,%eax
rep stosq
ret
CFI_ENDPROC
-ENDPROC(clear_page)
+ENDPROC(clear_page_c)

ENTRY(clear_page)
CFI_STARTPROC



\
 
 \ /
  Last update: 2009-06-30 15:03    [from the cache]
©2003-2010