Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH][RFC] asm-generic:remove calling flush_write_buffers() in dma_sync_*_for_cpu | Date | Tue, 30 Jun 2009 14:48:54 +0200 |
| |
On Tuesday 30 June 2009, Alan Cox wrote: > > Ok. The Winchip also does not have an IOMMU or the need for SWIOTLB, so > > I guess it would be ok to move the flush_write_buffers() out of the common > > code into the x86 pci-nommu implementation. That one is also the only > > place that calls flush_write_buffers() in dma_map_(). > > What about non x86 - this is asm-generic you are playing with and its the > kind of change that causes evil really hard to track down and subtle > corruptions and user data loss if you get it wrong.
Non-x86 is the real motivation for the patch, because the flush_write_buffers call in this file is currently not implemented and causes build errors on everything but x86, frv, ia64 and m32r, where the latter two implement it as an empty macro.
The only users of the file right now are x86 and ia64, and ia64 only added the empty flush_write_buffers() definition in order to use it.
Arnd <><
| |