lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/3] msm_sdcc: A few more cleanups
From
Date
On Tue, 2009-06-30 at 08:57 +0200, Pavel Machek wrote:
> diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
> - do_div(clks, NSECS_PER_SEC);
> + do_div(clks, NSEC_PER_SEC);

Compiling is good. Submitting uncompiled patches not so good...

> @@ -588,6 +588,8 @@ static void
> msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data,
> u32 status)
> {
> + void __iomem *base = host->base;
> +

I don't know how performance sensitive this is.

Maybe it should be inline and have base passed
as an argument.




\
 
 \ /
  Last update: 2009-06-30 14:33    [W:0.887 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site