Messages in this thread | | | Subject | Re: [PATCH 0/3] msm_sdcc: A few more cleanups | From | Joe Perches <> | Date | Tue, 30 Jun 2009 05:30:21 -0700 |
| |
On Tue, 2009-06-30 at 08:57 +0200, Pavel Machek wrote: > diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c > - do_div(clks, NSECS_PER_SEC); > + do_div(clks, NSEC_PER_SEC);
Compiling is good. Submitting uncompiled patches not so good...
> @@ -588,6 +588,8 @@ static void > msmsdcc_handle_irq_data(struct msmsdcc_host *host, struct mmc_data *data, > u32 status) > { > + void __iomem *base = host->base; > +
I don't know how performance sensitive this is.
Maybe it should be inline and have base passed as an argument.
| |