lkml.org 
[lkml]   [2009]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/5] power_supply: add a charge_type status to the api, and use it for olpc driver
    On Tue, Jun 30, 2009 at 02:17:30AM -0400, Andres Salomon wrote:

    > This adds a new sysfs file called 'charge_type' which displays the type of
    > charging (n/a, trickle charge, slow charge, or fast charging). This allows
    > things like battery diagnostics to determine what the battery/EC is doing
    > without resorting to changing the 'status' sysfs output.

    > Signed-off-by: Andres Salomon <dilinger@collabora.co.uk>

    This looks good to me. Could you please keep me on the CC for any
    future revisions of this patch, I can make use of this in the WM8350
    driver.

    > + static char *charge_type[] = {
    > + "N/A", "Trickle", "Slow", "Fast"
    > + };

    I'd be tempted to make "N/A" be "Unknown" to match the style of the rest
    of the attributes. I'm also not sure that we need a slow type, but
    equally it shouldn't do any harm.


    \
     
     \ /
      Last update: 2009-06-30 13:35    [W:0.027 / U:151.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site