Messages in this thread Patch in this message | | | Date | Thu, 4 Jun 2009 12:38:13 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded |
| |
On Wed, 03 Jun 2009 16:33:52 -0700 akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to > > http://userweb.kernel.org/~akpm/mmotm/ > > and will soon be available at > > git://git.zen-sources.org/zen/mmotm.git > It seems sysfs_create_link_nowarn() is removed in linux-next.patch but driver/base/node.c still includes it.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91
How should we fix it ? Folllowing is a quick hack for compile but ... should be clarified by memory hotplug guys.
==
sysfs_create_link_nowarn() is obsolete.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- Index: mmotm-2.6.30-Jun3/drivers/base/node.c =================================================================== --- mmotm-2.6.30-Jun3.orig/drivers/base/node.c +++ mmotm-2.6.30-Jun3/drivers/base/node.c @@ -279,7 +279,7 @@ int register_mem_sect_under_node(struct continue; if (page_nid != nid) continue; - return sysfs_create_link_nowarn(&node_devices[nid].sysdev.kobj, + return sysfs_create_link(&node_devices[nid].sysdev.kobj, &mem_blk->sysdev.kobj, kobject_name(&mem_blk->sysdev.kobj)); }
| |