lkml.org 
[lkml]   [2009]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/5] tracing/events: fix output format of user stack
    From: walimis <walimisdev@gmail.com>

    According to "events/ftrace/user_stack/format", fix the output of
    user stack.

    before fix:

    sh-1073 [000] 31.137561: <b7f274fe> <- <0804e33c> <- <080835c1>

    after fix:

    sh-1072 [000] 37.039329:
    => <b7f8a4fe>
    => <0804e33c>
    => <080835c1>

    Signed-off-by: walimis <walimisdev@gmail.com>
    LKML-Reference: <1244016090-7814-3-git-send-email-walimisdev@gmail.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/trace/trace_output.c | 11 +++++++----
    1 files changed, 7 insertions(+), 4 deletions(-)

    diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
    index 64596a5..8dadbbb 100644
    --- a/kernel/trace/trace_output.c
    +++ b/kernel/trace/trace_output.c
    @@ -389,17 +389,20 @@ seq_print_userip_objs(const struct userstack_entry *entry, struct trace_seq *s,

    if (ip == ULONG_MAX || !ret)
    break;
    - if (i && ret)
    - ret = trace_seq_puts(s, " <- ");
    + if (ret)
    + ret = trace_seq_puts(s, " => ");
    if (!ip) {
    if (ret)
    ret = trace_seq_puts(s, "??");
    + if (ret)
    + ret = trace_seq_puts(s, "\n");
    continue;
    }
    if (!ret)
    break;
    if (ret)
    ret = seq_print_user_ip(s, mm, ip, sym_flags);
    + ret = trace_seq_puts(s, "\n");
    }

    if (mm)
    @@ -1012,10 +1015,10 @@ static enum print_line_t trace_user_stack_print(struct trace_iterator *iter,

    trace_assign_type(field, iter->ent);

    - if (!seq_print_userip_objs(field, s, flags))
    + if (!trace_seq_putc(s, '\n'))
    goto partial;

    - if (!trace_seq_putc(s, '\n'))
    + if (!seq_print_userip_objs(field, s, flags))
    goto partial;

    return TRACE_TYPE_HANDLED;
    --
    1.6.3.1
    --


    \
     
     \ /
      Last update: 2009-06-03 17:23    [W:0.028 / U:0.696 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site