Messages in this thread | | | Date | Mon, 29 Jun 2009 22:43:50 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH, v3] eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS (was: [git pull request] ACPI & driver patches for 2.6.31-rc1) |
| |
On Mon, Jun 29, 2009 at 09:34:06PM +0200, Ingo Molnar wrote: > > * Len Brown <lenb@kernel.org> wrote: > > > Thanks for fixing this config, Ingo. > > > > I agree, our build system can handle "depends", > > but "select" does not deliver on what it advertises, > > making it a trap for programmers. > > Hm, this portion of Kconfig is a trap in a way indeed - on the other > hand it is also a useful tool and the simplistic approach to > disallow select altogether is a step backwards. > > IIRC either Vegard or Steve has come up with a patch series that > improved Kconfig to warn about problem selects while still allowing > the simple ones. That would deflect most of the bad uses while still > allowing the good uses. Not sure what happened to that series.
Steve came up with a patch that warned about problematic select only in a defconfig. It did not warn properly for all the problematic selects. I ran (as usual) out of time last time I looked :-( I would likely need a full day or two to come up with somthing, but these days finding an hour is not easy.
Sam
| |