Messages in this thread | | | Date | Mon, 29 Jun 2009 15:18:09 +0800 | From | Eric Miao <> | Subject | Re: [PATCH] /drivers/video/backlight/tdo24m - crash on kmalloc |
| |
Aviv Laufer wrote: > There is a crash in tdo24m module caused by a call to kmalloc with > the second parameter sizeof(flag) instead of flag. > > Signed-off-by: Aviv Laufer <aviv.laufer@gmail.com>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
> --- > > > --- linux-2.6.30/drivers/video/backlight/tdo24m.c.orig 2009-06-23 > 15:08:02.000000000 +0300 > +++ linux-2.6.30/drivers/video/backlight/tdo24m.c 2009-06-23 > 15:09:05.000000000 +0300 > @@ -356,7 +356,7 @@ static int __devinit tdo24m_probe(struct > lcd->power = FB_BLANK_POWERDOWN; > lcd->mode = MODE_VGA; /* default to VGA */ > > - lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, sizeof(GFP_KERNEL)); > + lcd->buf = kmalloc(TDO24M_SPI_BUFF_SIZE, GFP_KERNEL); > if (lcd->buf == NULL) { > kfree(lcd); > return -ENOMEM; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |