Messages in this thread | | | Date | Mon, 29 Jun 2009 17:31:21 +0100 | From | Alan Cox <> | Subject | Re: [PATCH][RFC] asm-generic:remove calling flush_write_buffers() in dma_sync_*_for_cpu |
| |
> Wouldn't it be better to put the flush_write_buffer in the specific > operation (swiotlb_sync_*_for_*) rather than the multiplexer? > > Maybe in that case, smp_wmb() would be more appropriate because > it is defined on all architectures.
smp_wmb() is stronger and it would slow down x86 if we did that (we'd go from no-op on a coherent platform to using mfence/lfence etc)
| |