[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] integrity: add ima_counts_put (updated)

    Mimi Zohar:
    > This patch fixes an imbalance message as reported by J.R. Okajima.
    > The IMA file counters are incremented in ima_path_check. If the
    > actual open fails, such as ETXTBSY, decrement the counters to
    > prevent unnecessary imbalance messages.

    Although I have no objection for this fix, I'd like to suggest you to
    stop incrementing the counters in ima_path_check().
    A while ago IMA_COUNT_LEAVE and ima_counts_get() were introduced, and
    now ima_counts_put() appears.
    Isn't it easier something like this,
    - stop incrementing in ima_path_check().
    - call ima_counts_get() in dentry_open() (or similar).
    - delete IMA_COUNT_LEAVE/UPDATE and ima_counts_put().

    How do you think?

    J. R. Okajima

     \ /
      Last update: 2009-06-29 16:15    [W:0.018 / U:108.280 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site