[lkml]   [2009]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v2] enable x2APIC without interrupt remapping under KVM
    On Mon, 2009-06-29 at 03:08 -0700, Gleb Natapov wrote:
    > - local_irq_save(flags);
    > mask_IO_APIC_setup(ioapic_entries);
    > - mask_8259A();

    Is there a reason why the 8259 mask/unmask operations are separated from
    io-apic mask/unmask operations.

    Can we keep it together so that it will be easy to read and understand
    that we first do the interrupt subsystem mask, try enabling IR and
    x2apic and unmask the interrupt subsystem.

    Otherwise I am ok with this change.


     \ /
      Last update: 2009-06-29 12:53    [W:0.024 / U:49.768 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site