Messages in this thread | | | Date | Mon, 29 Jun 2009 01:24:45 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2/2] exec: Make do_coredump more robust and safer when using pipes in core_pattern (v3) |
| |
On 06/29, Oleg Nesterov wrote: > > But in fact I don't really understand why do we need the new sysctl.
Sorry Neil, I misread the patch. This sysctls limits the number of coredumps to pipe in flight, not the number of "wait for ->readers == 0".
Agreed, perhaps makes sense. But imho a separate patch is better. And,
> Yes, > if the collecting process never exits, the coredumping thread can't be reaped. > But this process runs as root, it can do other bad things. And let's suppose > it just does nothing, say sleeps forever, and do not read the data from pipe. > In that case, regardless of any sysctls, ->core_dump() never finishes too.
so I think this core_pipe_limit is more or less orthogonal to "wait for complete".
Oleg.
| |