lkml.org 
[lkml]   [2009]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3 -tip] perf_counter tools: Add support to set of multiple events in one shot

    * Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:

    > Add support for HARDWARE and SOFTWARE events :
    > perf stat -e all-sw-events
    > perf stat -e sw-events
    > perf stat -e all-hw-events
    > perf stat -e hw-events

    > +static struct event_type_symbol event_type_symbols[] = {
    > + [PERF_TYPE_HARDWARE] = { "hw-events", "all-hw-events", },
    > + [PERF_TYPE_SOFTWARE] = { "sw-events", "all-sw-events", },

    Hm, this really just special-cases and open-codes these. The better
    solution is what i suggested in my review of your prior patches:
    regex pattern matching.

    Ingo


    \
     
     \ /
      Last update: 2009-06-27 18:41    [W:0.028 / U:59.212 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site