lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 18/19] drivers/video: Use PCI_VDEVICE
    On Fri, Jun 26, 2009 at 09:35:26AM -0700, Joe Perches wrote:
    > On Fri, 2009-06-26 at 12:54 +0300, Ville Syrjälä wrote:
    > > Perhaps there should be a PCI_VDDEVICE() or something for this type of
    > > stuff? Would make things even shorter.
    >
    > drivers/edac/edac_core.h has:
    >
    > #define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
    > PCI_DEVICE_ID_ ## vend ## _ ## dev
    >
    > Try submitting a patch and see what happens...

    Too lazy. I was thinking that since you're already looking at
    this stuff you might be tricked into doing some more work.

    > > It seems your script missed atyfb. It could use PCI_VDEVICE() too.
    >
    > Can you show an example please?

    I didn't read you script and didn't look at the patches too closely. It
    seems you only converted the open-coded stuff and not stuff already
    using the PCI_DEVICE() macro. atyfb falls into this category.

    --
    Ville Syrjälä
    syrjala@sci.fi
    http://www.sci.fi/~syrjala/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-26 19:33    [W:3.065 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site