lkml.org 
[lkml]   [2009]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 18/19] drivers/video: Use PCI_VDEVICE
    From
    Date
    On Fri, 2009-06-26 at 12:54 +0300, Ville Syrjälä wrote:
    > Perhaps there should be a PCI_VDDEVICE() or something for this type of
    > stuff? Would make things even shorter.

    drivers/edac/edac_core.h has:

    #define PCI_VEND_DEV(vend, dev) PCI_VENDOR_ID_ ## vend, \
    PCI_DEVICE_ID_ ## vend ## _ ## dev

    Try submitting a patch and see what happens...

    > Also PCI_VDEVICE() does not use named initializers for some reason.
    > Might be worth fixing.

    Perhaps that's to avoid mixing named and unnamed initializers.

    > It seems your script missed atyfb. It could use PCI_VDEVICE() too.

    Can you show an example please?

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-06-26 18:39    [W:3.922 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site