Messages in this thread | | | Date | Fri, 26 Jun 2009 12:54:54 +0300 | From | Ville Syrjälä <> | Subject | Re: [PATCH 18/19] drivers/video: Use PCI_VDEVICE |
| |
On Wed, Jun 24, 2009 at 10:13:34PM -0700, Joe Perches wrote: <snip> > + { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TS), rage_128_ultra }, > + { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TT), rage_128_ultra }, > + { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_RAGE128_TU), rage_128_ultra }, > { 0, } > };
Perhaps there should be a PCI_VDDEVICE() or something for this type of stuff? Would make things even shorter.
Also PCI_VDEVICE() does not use named initializers for some reason. Might be worth fixing.
It seems your script missed atyfb. It could use PCI_VDEVICE() too.
-- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |