Messages in this thread | | | Subject | Re: [PATCH] LED: Reply-To: use correct name for /sys/devices/virtual/leds/ entries | From | Richard Purdie <> | Date | Fri, 26 Jun 2009 11:01:27 +0100 |
| |
On Thu, 2009-06-25 at 19:46 -0700, Greg KH wrote: > On Thu, Jun 25, 2009 at 11:57:55AM +0100, Richard Purdie wrote: > > On Wed, 2009-06-24 at 15:33 -0700, Greg KH wrote: > > > From: Olaf Hering <olh@suse.de> > > > > > > This is needed to get kde-powersave to work properly on some g4 > > > powerbooks. > > > > > > From: Olaf Hering <olh@suse.de> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > > > I'm ok with this apart from: > > > > > --- a/drivers/leds/ledtrig-default-on.c > > > +++ b/drivers/leds/ledtrig-default-on.c > > > @@ -23,7 +23,7 @@ static void defon_trig_activate(struct l > > > } > > > > > > static struct led_trigger defon_led_trigger = { > > > - .name = "default-on", > > > + .name = "default::on", > > > .activate = defon_trig_activate, > > > }; > > > > which doesn't seem to match the patch description. Why does the trigger > > name need to be changed? > > I really don't know, I took this patch from the suse tree, and Olaf is > gone and I can't ask him :( > > If you don't think it is needed/correct, please drop that part. Or I > can redo it without it.
I'll just drop that bit. As far as I can see it would just break any users of that trigger for no good reason...
Cheers,
Richard
-- Richard Purdie Intel Open Source Technology Centre
| |