[lkml]   [2009]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] PCAP regulator driver (for 2.6.32).
    On Thu, Jun 25, 2009 at 05:29:53PM -0300, Daniel Ribeiro wrote:

    > + /*
    > + * The regulator framework doesn't like regulators which default
    > + * to ON at boot time, so we just disable it here (when it is safe).
    > + */
    > + if (pdev->id == VAUX2 || pdev->id == VAUX3)
    > + pcap_regulator_disable(rdev);

    No need to do this - the regulator framework is perfectly happy with
    regulators that are enabled at boot time and turning regulators that are
    actively being used off is likely to cause issues. Regulator drivers
    should just leave everything as they find it and leave it up to the core
    and machine drivers to make any changes.

    Other than that this looks good; I'm assuming the PCAP core has a
    sensible way of getting the platform data to the devices.

     \ /
      Last update: 2009-06-26 01:39    [W:0.305 / U:49.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site