Messages in this thread |  | | | Date | Thu, 25 Jun 2009 20:49:15 +0300 | | From | Baruch Siach <> | | Subject | Re: [PATCH] i2c: fix build bug in i2c-designware.c |
Hi Ben,
On Thu, Jun 25, 2009 at 06:40:00PM +0100, Ben Dooks wrote: > On Thu, Jun 25, 2009 at 08:32:21AM +0200, Ingo Molnar wrote: > > >From 8bf467c9f4591f77e1d69bd78fb6cc4f1ff387f8 Mon Sep 17 00:00:00 2001 > > From: Ingo Molnar <mingo@elte.hu> > > Date: Thu, 25 Jun 2009 08:27:14 +0200 > > Subject: [PATCH] i2c: fix build bug in i2c-designware.c > > > > This build error triggers on x86: > > > > drivers/built-in.o: In function `i2c_dw_init': > > i2c-designware.c:(.text+0x4e37ca): undefined reference to `clk_get_rate' > > drivers/built-in.o: In function `dw_i2c_probe': > > i2c-designware.c:(.devinit.text+0x51f5e): undefined reference to `clk_get' > > i2c-designware.c:(.devinit.text+0x51f76): undefined reference to `clk_enable' > > i2c-designware.c:(.devinit.text+0x520ff): undefined reference to `clk_disable' > > i2c-designware.c:(.devinit.text+0x52108): undefined reference to `clk_put' > > > > Because this new driver uses the clk_*() facilities which is an > > ARM-only thing currently. > > > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > > --- > > drivers/i2c/busses/Kconfig | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > > index d56351a..0760f25 100644 > > --- a/drivers/i2c/busses/Kconfig > > +++ b/drivers/i2c/busses/Kconfig > > @@ -334,6 +334,7 @@ config I2C_DAVINCI > > > > config I2C_DESIGNWARE > > tristate "Synopsys DesignWare" > > + depends on HAVE_CLK > > help > > If you say yes to this option, support will be included for the > > Synopsys DesignWare I2C adapter. Only master mode is supported. > > thanks, missed there not being a 'depends on' line... > > Baurch - can you submit a patch to declare which ARM architectures that > this runs on, or whether Ingo's dependency on HAVE_CLK is the fix to merge?
Ingo's fix should be enough.
baruch
-- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |