lkml.org 
[lkml]   [2009]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: TTM page pool allocator
Jerome Glisse skrev:
> Hi,
>
> Thomas i attach a reworked page pool allocator based on Dave works,
> this one should be ok with ttm cache status tracking. It definitely
> helps on AGP system, now the bottleneck is in mesa vertex's dma
> allocation.
>
> Cheers,
> Jerome
>
Hi, Jerome!
In general it looks very good. Some things that need fixing:

1) We must have a way to hand back pages. I still not quite understand
how the shrink callbacks work and whether they are applicable. Another
scheme would be to free, say 1MB when we have at least 2MB available.

2) We should avoid including AGP headers if AGP is not configured.
Either reimplement unmap_page_from_agp or map_page_into_agp or move them
out from the AGP headers. We've hade complaints before from people with
AGP free systems that the code doesn't compile.

3) Since we're allocating (and freeing) in batches we should use the
set_pages_array() interface to avoid a global tlb flush per page.

4) We could now skip the ttm_tt_populate() in ttm_tt_set_caching, since
it will always allocate cached pages and then transition them.

5) Use TTM_PFX in printouts.

/Thomas





\
 
 \ /
  Last update: 2009-06-25 17:57    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site