Messages in this thread | | | Subject | Re: [PATCH v2] slab,slub: ignore __GFP_WAIT if we're booting or suspending | From | Benjamin Herrenschmidt <> | Date | Thu, 25 Jun 2009 19:56:33 +1000 |
| |
> Maybe so. Masking off __GFP_WAIT up in slab and page allocator > isn't really needed though (or necessarily a good idea to throw > out that information far from where it is used). > > Checking for suspend active and avoiding writeout from reclaim > for example might be a better idea.
Ah ok. Yes, I agree. I'm not familiar with those code path and so masking gfp here sounded like the easier solution but you may well be right here :-)
> > So yes, just applying the mask would help, but wouldn't completely fix > > it unless we also find a way to synchronize. > > You could potentially use srcu or something like that in page > reclaim in order to have a way to be able to kick everyone > out. page reclaim entry/exit from the page allocator isn't such > a fastpath though, so even a simple mutex or something may be > possible.
Ok. Well, I'll leave that to the suspend/resume folks for now, as I'm way too busy at the moment to give that a serious look, but thanks for the pointer.
Cheers, Ben.
> -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
| |