Messages in this thread | | | Date | Thu, 25 Jun 2009 09:46:31 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [RFC PATCH] atmel_lcdfb Kconfig: remove long dependency line |
| |
On Tue, Jun 23, 2009 at 04:12:54PM +0200, Nicolas Ferre wrote: > Haavard Skinnemoen : > > Nicolas Ferre wrote: > >> +config ARCH_ATMEL_HAS_FB > >> + bool > >> + depends on FB > >> + default n > > > > What happens when we unconditionally select something which depends on > > something else? > > :-P > > Experience shows that this configuration is selected. > > The dependency allows to have a good hierarchy in the configuration tree... > Better proposition welcome.
1st - no need for 'default n' - you're specifying something that's already the default.
2nd - don't make this symbol depend on anything, and don't use the symbol for anything except providing a dependency for FB_ATMEL. Instead, let FB_ATMEL deal with the dependency on FB and ARCH_ATMEL_HAS_FB.
3rd - ISTR we have a convention for these - 'HAVE_foo' for a configuration option named 'foo'. So it should probably be HAVE_FB_ATMEL.
| |