lkml.org 
[lkml]   [2009]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/pci: don't use crs for root if we only have one root bus
On Wed, Jun 24, 2009 at 04:09:36PM -0700, Linus Torvalds wrote:
>
> Should we not just revert 9e9f46c44e487af0a82eb61b624553e2f7118f5b?
>
> The thing says:
>
> "At this point, it seems to solve more problems than it causes, so let's
> try using it by default. It's an easy revert if it ends up causing
> trouble."
>
> and it clearly does _not_ solve more problems than it causes, and the
> whole message in that commit implies we should revert it.
>
> I'm happy to apply various patches to fix it up, but regardless, I thinkwe
> should revert that commit as bogus. We can try making it the default again
> next round, when maybe it will be true that it doesn't cause issues.
>
> What did it even ever help with?

In our case it is needed on some of our systems for PCI hotplug to
avoid MCKs due to a device under one root bus getting a resource
during hotplug that can only be used by devices under a different
root bus. If the user does not intend to use PCI hotplug, the
function isn't needed (i.e. 'pci=use_crs' can be omitted) because
resources are properly directed to the installed cards via BIOS
pre-assignment.

Gary

--
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com
http://www.ibm.com/linux/ltc



\
 
 \ /
  Last update: 2009-06-25 02:03    [W:0.068 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site