Messages in this thread | | | Date | Wed, 24 Jun 2009 09:46:59 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH V2] futex: Fix the write access fault problem for real |
| |
On Wed, 24 Jun 2009, Thomas Gleixner wrote: > > The solution is to not rely on access_ok and get_user() for any write > access related fault on private and shared futexes. Instead we need to > fault it in with verification of write access. > > There is no generic non destructive write mechanism which would fault > the user page in trough a #PF, but as we already know that we will > fault we can as well call get_user_pages() directly and avoid the #PF > overhead.
Ack. Patch looks saner this way, and the commit message explains the issues.
Linus
| |