Messages in this thread | | | Date | Wed, 24 Jun 2009 11:39:09 -0500 | From | Joel Schopp <> | Subject | Re: [PATCH] pseries: cpu: Reduce the polling interval in __cpu_up() |
| |
> > The code needs testing on other powerpc platforms. > I think given the numbers you showed this is a good improvement, and it clearly can't do any harm on platforms that implement msleep correctly.
For what it's worth: Acked-by: Joel Schopp <jschopp@austin.ibm.com> > Signed-off-by: Gautham R Shenoy <ego@in.ibm.com> > --- > arch/powerpc/kernel/smp.c | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c > index 65484b2..00c13a1 100644 > --- a/arch/powerpc/kernel/smp.c > +++ b/arch/powerpc/kernel/smp.c > @@ -411,9 +411,8 @@ int __cpuinit __cpu_up(unsigned int cpu) > * CPUs can take much longer to come up in the > * hotplug case. Wait five seconds. > */ > - for (c = 25; c && !cpu_callin_map[cpu]; c--) { > - msleep(200); > - } > + for (c = 5000; c && !cpu_callin_map[cpu]; c--) > + msleep(1); > #endif > > if (!cpu_callin_map[cpu]) { > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >
| |