lkml.org 
[lkml]   [2009]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v5][PATCH 1/4] intel_txt: Intel(R) TXT boot support
On Mon, 22 Jun 2009, Joseph Cihula wrote:


> +void tboot_copy_fadt(const struct acpi_table_fadt *fadt)
> +{
> +#define TB_COPY_GAS(tbg, g) \
> + tbg.space_id = g.space_id; \
> + tbg.bit_width = g.bit_width; \
> + tbg.bit_offset = g.bit_offset; \
> + tbg.access_width = g.access_width; \
> + tbg.address = g.address;
> +
> + TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1a_cnt_blk,
> + fadt->xpm1a_control_block);
> + TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1b_cnt_blk,
> + fadt->xpm1b_control_block);
> + TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1a_evt_blk,
> + fadt->xpm1a_event_block);
> + TB_COPY_GAS(tboot_shared->acpi_sinfo.pm1b_evt_blk,
> + fadt->xpm1b_event_block);

Not a showstopper, but why not simply make a static tb_copy_gas()
function?

--
James Morris
<jmorris@namei.org>


\
 
 \ /
  Last update: 2009-06-24 12:47    [from the cache]
©2003-2011 Jasper Spaans