Messages in this thread | | | Date | Wed, 24 Jun 2009 18:17:09 +0900 | From | Hidehiro Kawai <> | Subject | Re: [PATCH 11/15] HWPOISON: The high level memory error handler in the VM v8 |
| |
Andi Kleen wrote:
>>introduce invalidate_inode_page() and don't remove dirty/writeback pages >>from page cache (Nick, Fengguang) > > I'm still dubious this is a good idea, it means potentially a lot > of pages not covered.
I think this is not bad idea for now. Certainly we become unable to recover from uncorrected memory error on dirty page cache pages, it will be safer than the old patch.
As for ext3 filesystem, unlike usual I/O error, the I/O error generated by HWPOISON feature doesn't cause journal abort and read-only remount even if the fs has been mounted with data=ordered and data_err=abort options. So we can re-read the old data and update the fs after failing to write out dirty data, this may cause an integrity problem. And improper data can be exposed by the re-read if it's a newly allocated data block.
The amount of dirty pages are not so many because it is limited by dirty_ratio or dirty_bytes. HWPOISON feature is still useful even if it doesn't cover dirty page cache pages. :-)
Regards, -- Hidehiro Kawai Hitachi, Systems Development Laboratory Linux Technology Center
| |